search

ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
221 stars 36 forks source link

Add true durability #1011

Closed Infernopickaxe closed 5 years ago

Infernopickaxe commented 5 years ago

For armor and tools that go above the normal durability amount as in 2b2t's "unbreakables" (not really unbreakable) I would like it if it displays in the armor hud, hovering over the item, and seeing it in player name tags (I believe the items have a high negative damage value)

LeafHacker commented 5 years ago

Minecraft doesn't support modifying the durability of a tool, so the concept of a higher durability tool doesn't make sense.

Instead items have a damage value which counts up until maxDamage is reached and the item is destroyed.

I suspect that maybe you are talking about enchantments, perhaps the item has a high level Unbreaking enchantment or something?

Infernopickaxe commented 5 years ago

No I'm talking about durability Another client already has true durability On 2b2t we have "unbreakables" the durability of these items are in the thousands (max being the original durability + 32767) (The lowest durability possible is -32767 + the original durability of the item)

LeafHacker commented 5 years ago

That doesn't make sense. The -32,768 to +32,767 is a 16bit short, which enchantment levels are stored as. However damage and maxDamage are both stored as 32bit ints which has a range of -2,147,483,648 to +2,147,483,647 ("durability" remaining is calculated on the fly as maxDamage - damage).

I'd love to see a screenshot/gif/video/whatever of one of these items, or a /give command of how they were originally hacked in (and in which version).

Infernopickaxe commented 5 years ago

Do you have a discord?

LeafHacker commented 5 years ago

Yes, here. Btw this probably a duplicate of #957

Infernopickaxe commented 5 years ago

Yeah I just joined in github I didnt see that one

LeafHacker commented 5 years ago

np it wouldn't have been easy to find since damage/durability isn't in the title. Anyway back on topic do you have anything showing the characteristics of these items? Have you interacted with these yourself or simply heard about them somewhere (if so where)?

Infernopickaxe commented 5 years ago

Trying to find the screenshot

Infernopickaxe commented 5 years ago

image Add an extra line on the tooltip similar to this for damage information

LeafHacker commented 5 years ago

I don't think this adds anything that the vanilla game doesn't already do. Vanilla already shows Durability: 3204/1561, the only thing added in the screenshot is the damage (-1643) which is - durability + maxDamage (since durability = maxDamage - damage)

leijurv commented 5 years ago

Added in 4.6 - vanilla doesn't show the durability if damage is negative, so we added an option to make it always show.