ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
216 stars 36 forks source link

fast interact bad #1160

Open niggish opened 5 years ago

niggish commented 5 years ago

fast interact bugged

fast interact delays/speeds are broke, if fastbreak delay is at 1 or higher, you cant break blocks. if fast place speed is under 3, you cant place blocks if fast use speed is under 3, you cant do anything

Cerbiac commented 5 years ago

Describe the bug Fast Interact subvalues only have 2 modes across their ranges, off and no delay. Which also limits the customizability of it when it does nothing, so this is also a suggestion thread at the same time. (The action always works, off and no delay refer to how the action repeats when held down.)

Possible Values and Effects - `Place Speed` set to `0-3`: Off - `Place Speed` set to `4-5`: No Delay - `Break Delay` set to `0-1`: No Delay - `Break Delay` set to `2-5`: Off - `Use Speed` set to `0-3`: Off - `Use Speed` set to `4-5`: No Delay

To Reproduce

  1. Enable Fast Interact & all Values
  2. Change subvalues.
  3. Test module.
  4. Pattern should follow details above.

Expected behavior It would be a speed scalar, but it is pretty limited even if it was functional, so I'm going to add a suggestion part here.

Describe the solution you'd like Fast Place and Fast Use would have values APS (Actions per Second) with a range of 0-20 and also maybe TPS Sync. Fast Place would simply have Delay with a range of 0-1000ms. (0ms isn't possible, but it'll try nevertheless if set as so, presumably.)

Describe alternatives you've considered Possibly more values like Jitter like auto modules have.

Additional Client Info - Impact Version: 4.6 for 1.13.2 - Using Optifine? No - Using LiteLoader? No - Enabled mods: `Fast Interact` - Operating System: Windows 10 64bit