search

ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
219 stars 36 forks source link

[FEATURE] Properly deauthenticate alts. #1466

Open ghost opened 5 years ago

ghost commented 5 years ago

Is your feature request related to a problem? Please describe. Impact does not deauthenticate alts upon logout. This really bugs me, because I usually relog if the Server tells me my session is invalid/I am playing on Cracked. I have to actually restart my client or re-add the client. Trust me, it's annoying.

Describe the solution you'd like A reauthenticate/deauthenticate button .

Describe alternatives you've considered Impact deauthenticating alts by default. Why wouldn't you?

Additional context Restarting Impact takes time. This time is wasted. Forever gone.

0-x-2-2 commented 5 years ago

What? There is no such thing as "deauthentication" for Minecraft accounts.

LeafHacker commented 5 years ago

There is no such thing as "deauthentication"

Impact currently keeps any sessions it gets from mojang in memory and re-uses them when switching between alts. I'm guessing this is asking us to either not do that or add a way to manually re-authenticate.

ghost commented 5 years ago

LeafHacker nailed it

LeafHacker commented 5 years ago

It's tempting to remove session caching completely - that way we wouldn't need a "log out" or "re-authenticate" button, but there's plenty of good reasons to cache sessions.

For one thing it avoids getting rate-limited from logging in too often (may not be an actual issue, but i do notice it sometimes when repeatedly running in debug mode with username/password login).

Secondly it makes switching back and forth between alts faster.

I wonder if there's a quick/cheap way to verify if a session is still valid automatically, if a session is known to be invalid we can just mark that alt as logged out/unauthenticated.

ghost commented 5 years ago

Is creating a Minecraft server which spits out "Alt name OK"in online mode, then connecting to it and therefore checking the Alt?