Move to modlauncher

[LeafHacker]

legacylauncher/launchwrapper is bad modlauncher is good, mkay.

• [ ] Use ForgeGradle 3.0 in all branches
• [x] Update to Mixin 0.8
• [ ] Create a UserDev distribution equivalent to forge's net.minecraftforge:forge
• [ ] Implement ITransformationService (and/or maybe ITransformer)
• [ ] Ensure the installer json generates correctly
• [ ] Break anything that fixes

[0-x-2-2]

This should only be done for 1.14.4 because only the latest 1.14.4 preview of OptiFine works with ModLauncher however It might assume it is running in Forge so that might be an issue.

Create a UserDev distribution equivalent to forge's net.minecraftforge:forge

This already exists in the Impact Maven and it is really just a config file in a jar file so it can be auto-generated easy.

[LeafHacker]

This should only be done for 1.14.4 because only the latest 1.14.4 preview of OptiFine works with ModLauncher

hmmm, tbh I wouldn't mind breaking optifine support... I guess we could have both a Tweaker and a ITransformationService (or maybe ITransformer) and use launchwrapper/tweaker on optifine installs... 😢

This already exists in the Impact Maven

The one in the impact maven is a hacky manually assembled jar. The tickbox here is for an actual project that builds the jar from a gradle config and includes the actual start class.

[0-x-2-2]

The one in the impact maven is a hacky manually assembled jar. The tickbox here is for an actual project that builds the jar from a gradle config and includes the actual start class.

The "hacky" jar can be generated super easy with a Gradle extension and the start class is not required at all.

main 'net.minecraft.launchwrapper.Launch' // use launchwrapper or modlauncher as the entrypoint here
args '--gameDir', '.' // use current working directory
args '--version', '1.14.4' // game version shown in f3 and snooper settings
args '--assetsDir', downloadAssets.output
args '--assetIndex', '{asset_index}'
args '--accessToken', 'INVALID'

[LeafHacker]

only issue with directly using launchwrapper/modlauncher is logging in, the main purpose of the LaunchTesting class is authenticating with mojang. I'm not opposed to generating the jar with a gradle plugin or task or whatever, although the concept I was going for is already mostly done at /ImpactDevelopment/UserDev.

[0-x-2-2]

"https://github.com/ImpactDevelopment/UserDev" does not exist 🤔

[0-x-2-2]

oops

[0-x-2-2]

only issue with directly using launchwrapper/modlauncher is logging in, the main purpose of the LaunchTesting class is authenticating with mojang.

What is the point of this when Impact has an AccountManager that does the same thing 🤔?

[LeafHacker]

"https://github.com/ImpactDevelopment/UserDev" does not exist

Oops was still private, published now.

Impact has an AccountManager that does the same thing ?

1. Convienence
2. DRM - our current premium check for nightlies etc runs in our dev environment, so we must be logged in to start the game (improving that is a separate issue lol)

[0-x-2-2]

1, Convienence

I can disagree because if you are crashing/launching over and over and your account gets locked you can no longer start the game.

2. DRM - our current premium check for nightlies etc runs in our dev environment, so we must be logged in to start the game (improving that is a separate issue lol)

LEAKED TOP SECRET code that (((leijurv))) DOES NOT want you to know about.

// Minecraft Creeper Skin Code for Minecraft Demo (NOT A CRACK).
args '--$$$$', '$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$$'

[leijurv]

Wtfr*ck about to ask Github to dmca takedown that comment due to https://en.wikipedia.org/wiki/Anti-circumvention laws

[0-x-2-2]

WTF!!!! I did nothing wrong I was just showing how you can get the creeper skin on the Minecraft demo (NOT A CRACK CANT JOIN SERVERS).

[0-x-2-2]

I was able to build these 2 (two) lines of code in a cave with a box of scraps. @leijurv