search

ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
221 stars 36 forks source link

Move mixin config to build.gradle #1678

Open LeafHacker opened 5 years ago

LeafHacker commented 5 years ago

Currently our mixin configs are specified in static json files in Resources. This comment implies that you can configure that stuff directly in build.gradle. We should do that.

If MixinGradle doesn't support generating the config.json automatically, we could just add a processResources task to JsonBuilder it.

0-x-2-2 commented 5 years ago

This comment implies that you can configure that stuff directly in build.gradle. We should do that.

That comment was just a suggestion and it was not implemented. What was implemented was parent configs.

If MixinGradle doesn't support generating the config.json automatically, we could just add a processResources task to JsonBuilder it.

processResources will only work for building jars via Gradle not running in IDE afaik.

LeafHacker commented 5 years ago

processResources works fine if you tell intellij to run via gradle instead of its own meme.

0-x-2-2 commented 5 years ago

processResources works fine if you tell intellij to run via gradle instead of its own meme.

I don't think the debugger works if you do that.

LeafHacker commented 5 years ago

processResources works fine if you tell intellij to run via gradle instead of its own meme.

I don't think the debugger works if you do that.

We do that on impact and it works fine. There was an intellij version that broke it kinda on some systems but it's fixed again.

0-x-2-2 commented 5 years ago

We do that on impact and it works fine. There was an intellij version that broke it kinda on some systems but it's fixed again.

Seems like the debugger does work now but the runClient task does not allow for custom game arguments but ForgeGradle might have something for this. Does this work if you have source sets like Baritone?

LeafHacker commented 5 years ago

the runClient task does not allow for custom game arguments

Idk, I've always used the run configs generated by genIntellijRuns. Never had a need to use runClient.

0-x-2-2 commented 5 years ago

Idk, I've always used the run configs generated by genIntellijRuns. Never had a need to use runClient.

Then processResources will not work because afaik IntelliJ builds that not Gradle.

LeafHacker commented 5 years ago

I'm telling you it does. Literally just set 

<application>
  <component name="GradleSystemRunningSettings">
    <option name="useGradleAwareMake" value="true" />
  </component>
</application>

In .idea/gradle.run.settings.xml

0-x-2-2 commented 5 years ago

wew