search

ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
221 stars 36 forks source link

Add a module to prevent being kicked by badly compressed chunks #1980

Open 5HT2 opened 4 years ago

5HT2 commented 4 years ago

If you load a chunk that has too much data the server kicks you, causing a temporary ban until that chunk is fixed. Adding a module that does this would help. #1305 is similar, but you still need that issue in case auto walking gets stuck in one of those chunks.

2019-12-19_00 23 44

See this MixinNettyCompressionDecoder.java for how it works

0-x-2-2 commented 4 years ago

This does not prevent the server from sending this packet therefore this won't even work on spigot/bungee so servers like 2b2t/constantiam. There is a lot better way to solve this and this is not it because you can literally just load the chunk like normal on the client.

5HT2 commented 4 years ago

This works on 2b from what I have heard. If there is a better solution like loading it properly, I'd love to see how that works

0-x-2-2 commented 4 years ago

This works on 2b from what I have heard.

Fake news AntiBookBan in Future is the proper but simular method and has not worked over a year now due to the kick being on the server-side now due to some spigot changes before 1.12.2 support was dropped.