ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
220 stars 36 forks source link

[Nightlies] Provide user feedback if account is non-donator #2113

Open MightyKnight opened 4 years ago

MightyKnight commented 4 years ago

Is your feature request related to a problem? Please describe. Currently Impact nightly just crashes when trying to start the game with a non-donator account. This can be problematic when a user downloads the wrong installer or when a donator uses the wrong account.

It's less than ideal, because:

Describe the solution you'd like Provide some form of user feedback that the account is not a donator:

e.g.: You can only launch this version of Impact if your account has donator status. Donate at https://impactclient.net/#donate. If you think this message shouln't appear, go to our [Discord]() and aks for help there.

This issue is for discussion on how to solve this problem. Some questions to think about:

  1. Where and how to display a message? (display ingame with all mods disabled OR force a normal minecraft crash and write it there)
  2. Exact wording of the message

Additional information

This is generated in the latest.log after in a wrong launch: ``` Error getting Impact API token from minecraft login java.io.IOException: /login/minecraft is not ok, it's 401 at net.impactclient.1H.0(1H.java:18) at net.impactclient.0GE.(0GE.java:36) at net.impactclient.75.1(75.java:10) at net.impactclient.0Ga.1(0Ga.java:22) at net.impactclient.32.0(32.java:9) at dbn.handler$init$zzp000(SourceFile:2518) at dbn.(SourceFile:548) at net.minecraft.client.main.Main.main(SourceFile:166) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) ```
MightyKnight commented 4 years ago

Pros for introducing a visible crash message

LeafHacker commented 4 years ago

I agree the current solution is less than ideal. Personally, I think we should show a Minecraft GUI screen saying something like “Cannot authenticate Impact Account”.

XPLilith commented 4 years ago

that'd be hot af

5HT2 commented 4 years ago

Instead of Cannot authenticate Impact account, which can be confusing to new users as they may think they need an Impact account to us it, when donating is the issue, it should be straight to the point and say something like "Error: Impact Premium launched without Premium account"

LeafHacker commented 4 years ago

Instead of Cannot authenticate Impact account [it should] say something like "Error: Impact Premium launched without Premium account"

Maybe, however that isn't the only reason authentication could fail. For example the user could be offline.

5HT2 commented 4 years ago

Oh true. But you should it more clear you need premium