search

ImpactDevelopment / ImpactIssues

Please use this repo to report bugs and request features
https://impactclient.net/
220 stars 36 forks source link

Add Java 11 compatibility #982

Closed DarkoGNU closed 5 years ago

DarkoGNU commented 5 years ago

What is your suggestion?

Vanilla Minecraft, OptiFine (usually this is needed: https://github.com/sp614x/optifine/files/2342731/NewerJavaCompatibility.zip), and possibly other hacked clients - I tested only Wurst, it works out of the box... they all work fine with Java 11, the latest LTS release. Can you add Java 11 support to Impact? I don't see any advantages besides a little performance improvement, but I just like using the latest available software, so Java 11 makes me happy :smiley:

Why is it useful?

Java 11 is the default JRE on many Linux distros, so people who downloaded the latest Java won't have to install Java 8 just to run Impact. They also won't have to change Java executable in Impact profile (or default Java version).

SuperOP535 commented 5 years ago

You should be able to add the NewerJavaComp thing manually

LeafHacker commented 5 years ago

This isn't (just?) an Impact issue, this is an upstream issue in legacylauncher/launchwrapper. This is one of the main reasons cpw is replacing launchwrapper with modlauncher going forward. The 1.13 version of Impact will likely use modlauncher and this should be resolved.

Best practice on linux is to configure JRE=8 as a dependancy of Minecraft to ensure mods & old versions using lanuchwrapper run correctly, see discussion on the AUR for example. There's no reason why JRE 8 can't exist along side other versions either, and it doesn't have to be the default for other programs either - just minecraft.

ZeroMemes commented 5 years ago

This is a Minecraft/LegacyLauncher issue lmao, Impact itself will work fine with Java 11

0-x-2-2 commented 5 years ago

The same thing you used with optifine should also work with impact.

DarkoGNU commented 5 years ago

Well... Impact with Java 11 doesn't work for me, even though OptiFine works https://paste.ee/p/Zko1x

0-x-2-2 commented 5 years ago

lol upstream issue again

ZeroMemes commented 5 years ago

Won't Fix: This issue is caused by Mixin. The appropriate place to address the issue would be on that repository.