Feedback on 0.9 suggested that removing the ability to install Impact for OptiFine against an already installed OptiFine (without providing that OptiFine's installer jar) was a step backwards.
This PR adds back the OptiFine Version drop down, replacing the None option with 0.9's OptiFineToggleSetting and adding a Custom option in order to access 0.9's OptiFineFileSetting.
Further feedback suggested disabling the Install button when no OptiFine file has been selected.
This has a minor breaking change to the API used by Impact: Impact will now need to set OptiFineToggleSetting to true in addition to setting OptiFineSetting.
leijurv
commented
4 years ago
Feedback on 0.9 suggested that removing the ability to install Impact for OptiFine against an already installed OptiFine (without providing that OptiFine's installer jar) was a step backwards.
This PR adds back the
OptiFine Versiondrop down, replacing theNoneoption with 0.9'sOptiFineToggleSettingand adding aCustomoption in order to access 0.9'sOptiFineFileSetting.Further feedback suggested disabling the Install button when no OptiFine file has been selected.
This has a minor breaking change to the API used by Impact: Impact will now need to set
OptiFineToggleSettingto true in addition to settingOptiFineSetting.