ImpactDevelopment / Installer

The installer
https://impactclient.net/
Other
81 stars 13 forks source link

Potential fix for the null settings issue #102

Closed LeafHacker closed 4 years ago

LeafHacker commented 4 years ago

When going from Vanilla + 1.15.2 to Forge, the version becomes blank, leading to other settings becoming null. This was revealed by some exceptions I added in 0.9.1.

This PR removes those exceptions (replacing them with log messages and nullable methods) but it may be better to fix the underlying issue instead:

image

LeafHacker commented 4 years ago

Looks like this is the root cause. 1.15.2 is still considered a "valid" setting, even when it isn't in the list of "possible values". This leads to other setting values becoming null and then 0.9.1 throwing exceptions building the GUI.

Setting validation was effectively disabled for the MinecraftVersion setting so that a custom version json could be supplied. Perhaps we need a more explicit way to bypass setting validation?

LeafHacker commented 4 years ago

Fixed in 0.9.2