ImpactMarkets / impact-markets-app

Other
2 stars 0 forks source link

Enhance comments #108

Closed goblinodds closed 1 year ago

goblinodds commented 1 year ago
  1. Add a field “type” (or maybe there’s a better name that doesn’t collide with reserved terms so much?) to the comment model
  2. Define four types: Comment, Q&A, reasoning, and endorsement
  3. Split the comment section into four tabs (one tab is already there): Comments, Questions & Answers, Reasoning, and Endorsement
  4. A comment posted in tab Reasoning should automatically get the type reasoning set, and so on

I haven’t thought much about the names of the fields and values, so feel free to pick something better. :-)

goblinodds commented 1 year ago

@Telofy

Just realized I included my questions in the commit but probably should've put them here instead:

Telofy commented 1 year ago
  1. “Type your comment here” seems good to me.
  2. Oh, hmm. I’d guess that it doesn’t matter. We’ll see.
  3. Great!
  4. If a new column is created with a default value of comment, then all the old comments should automatically receive that default value. If my assumptions are somehow wrong, and that doesn’t happen, then we’ll need a data migration to set the category correctly.
  5. Huh! I’ll have a look when I review the code. Thanks for checking!