Impelon / Disenchanter

A small Mod for MinecraftForge essentially adding a block to disenchant items.
https://minecraft.curseforge.com/projects/the-disenchanter-mod
BSD 2-Clause "Simplified" License
7 stars 13 forks source link

Enchanting Tweaks closes Disenchanting GUI #64

Open RazorWolvendom opened 1 year ago

RazorWolvendom commented 1 year ago

when i try to spam rightclick on it i can see the GUI for like a milisecond before it closes itself again, ive teseted few versions of the mod already and it didnt helped so maybe some of the mods i use you might know that could cause problems with it.

Mods: AmbientSounds AnvilFix BetterCaves BetterMineshafts BetterPortals Bloodmoon Carryon Cavern 2 Champions Clumps Construct's Armory Corpse CustomNPCs Damage Indicator Enchanting Tweaks <--- Enchantments Control <--- Extended Items and Ores Extra Bows Extra Golems Fast Leaf Decay FTB Ultimine Future MC Huds Iron Chest Just Enough Items Level Up Reloaded Leveled Difficulty LevelHearts Midnight Mo' Bends Mo' Villages Overlord Progressive Bosses RTG Roguelike Dungeons RPG-Hud Scape & Run: Parasites Smelting Sound Physics Spiders 2.0 Stack Up Tinkers' Construct Unique Enchantments Base <--- Unique Enchantments Battle <--- Unique Enchantments Utilities <--- Village Spawn Point Waila Wolf Armor and Storage
Libraries: Collective CreativeCore Mantle Shadowfacts' Forgelin
Impelon commented 1 year ago

Hey! :slightly_smiling_face: Unfortunately I do not know how those enchanting mods interact with Disenchanter. If the GUI closes after it opens, it could close because of an exception. If I could look at the log after you started up the game and tried to open the GUI once, I might be able to directly infer what went wrong or at the least which mod is conflicting.

Otherwise, you could always try to load a test-world with only the Disenchanter mod and individually add mods to see which are conflicting, starting with the ones you think are the problem. That way we could also nail down the mod that causes the incomparability and I could investigate why it would have a problem with my GUI. Though finding an exception in the game log would probably be faster, if the closing is indeed caused by an exception (which I strongly suspect) ^^

RazorWolvendom commented 1 year ago

here is the log

i found the target:

Enchanting Tweaks Mod https://www.curseforge.com/minecraft/mc-mods/enchanting-tweaks

i tried to use that mod by attempting to fix the parameters of the Enchantment Control mod because when i got for example a Protection 7 Book and wanted to use the anvil with it the item would only recieve protection 4 as output weirdly even tho i changed the max level to a higher limit.

Impelon commented 1 year ago

Alright, the log does not contain a related exception, unfortunately. Yet, with the information that it only occurs with Enchanting Tweaks Mod, I was able to find out what causes the problem. I have reported it there: Block-Vader/Enchantment-tweaks/issues/17

Basically, Enchanting Tweaks has a feature that opens a custom enchantment GUI when the TileEntity of an enchanting table is opened. The TileEntity for the disenchanting table extends the TileEntity of an enchanting table, and thus Enchanting Tweaks wrongly thinks you're opening a regular enchanting table and tries to replace the GUI.

But it seems like Enchanting Tweaks no longer gets updates, so I would not expect them to resolve this minor issue. The good thing is that this GUI-behaviour is controlled by Modify enchanting table in the config. If you turn off that feature, this incomparability should disappear.

If you however want to use the features related directly to the enchanting table you will not be able to.

Impelon commented 1 year ago

I've also included a small note in the FAQ section of the project site on CurseForge, so anyone with the same problem should hopefully be able to solve it.