Clean up PKGBUILD a bit - Githubissues

ImperatorStorm / PKGBUILDs

PKGBUILDs for packages I maintain

4 stars 1 forks source link

Clean up PKGBUILD a bit #9

Closed ISSOtm closed 2 years ago

ISSOtm commented 2 years ago

Hi! It's been a while. The recent comment on Aseprite breaking after the {fmt} 9.x update made me look into the PKGBUILD again, since it prints a warning during the build. This led to the following:

Remove unused Skia config flags [and add a lengthy comment about why the flags are there]
Disable two unnecessary Skia features [note: I did some light testing and it seemed fine, but I'm far from 100% coverage]
Remove a duplicate LAF config flag
Correct use of wrong variable in package()

Additionally, patches are currently applied with offsets, and one even with fuzz. Should we freshen those, or is is not worth the trouble?

ImperatorStorm commented 2 years ago

Wrt patches, if its just offset its probably fine, though fuzz and outright breakage should be fixed.

ImperatorStorm commented 2 years ago

Also, I'm going to fix buildscript for PRs soon.

ImperatorStorm commented 2 years ago

Not at computer so I can't check for myself, is it possible to version pin shared libraries in PKGBUILD?

ISSOtm commented 2 years ago

This is done automatically at build time:

If the dependency name appears to be a library, e.g. depends=('libfoobar.so'), makepkg will try to find a binary that depends on the library in the built package and append the soname version needed by the binary. Appending the version yourself disables automatic detection, e.g. depends=('libfoobar.so=2').

ImperatorStorm commented 2 years ago

Can you rebase onto current master? Doesn't look like Github'll re-run PR CI on upstream's workflows.

ImperatorStorm commented 2 years ago

https://github.com/ImperatorStorm/PKGBUILDs/pull/9#issuecomment-1236428755

Github's being a pain, and doesn't document how I would go about this as best I can tell.

Just gonna merge this and hope it works.

ISSOtm commented 2 years ago

Thanks!