search

ImperialCollegeLondon / FINESSE

A graphical user interface for controlling and monitoring an interferometer device
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Add functional test that all hardware set files are valid #670

Closed alexdewar closed 4 weeks ago

alexdewar commented 4 weeks ago

While we test the _load_builtin_hardware_sets() does what it's supposed to by using mocking, we don't test that the actual YAML files bundled with FINESSE are valid, which is a potential error source (e.g. if a device class name changes and a config file isn't updated, then we won't notice until a user tries to actually use the file).

Let's just ensure that all the built-in hardware set config files load properly.

I'm not sure why we don't do this already tbh.

@dalonsoa I thought this might be useful for your PR #669.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.96%. Comparing base (4cfd5ed) to head (9e87b05). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #670 +/- ## ======================================= Coverage 84.96% 84.96% ======================================= Files 69 69 Lines 3453 3453 ======================================= Hits 2934 2934 Misses 519 519 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.