search

ImperialCollegeLondon / FINESSE

A graphical user interface for controlling and monitoring an interferometer device
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Reorganise hwset code #678

Closed alexdewar closed 3 weeks ago

alexdewar commented 3 weeks ago

This PR purely involves moving some code around. I started doing it as part of my work on #638, but figured it probably makes sense to do this as a separate PR so all this churn doesn't appear in the diff for the functional changes I want to make.

Currently we have a finesse.gui.hardware_set.hardware_set module and I thought it just made more sense to move everything to the parent module (i.e. finesse.gui.hardware_set), so that's what I've done. There's also a module finesse.gui.hardware_set.device_connection with just a couple of functions in it, so I've moved these to the parent module too.

No functional changes intended.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.96%. Comparing base (f014b51) to head (7bf3023).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #678 +/- ## ========================================== - Coverage 84.99% 84.96% -0.03% ========================================== Files 69 68 -1 Lines 3459 3453 -6 ========================================== - Hits 2940 2934 -6 Misses 519 519 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexdewar commented 3 weeks ago

There's not a lot that we gain really tbh... I started out by moving a couple of enums out of hardware_set.py into __init__.py then possibly got a little carried away after that :stuck_out_tongue:. You're probably right that it makes more sense to keep most of this in its own submodule.

alexdewar commented 3 weeks ago

Maybe I'll just shelve this. I'm not sure it's worth it after all.