ImperialCollegeLondon / FINESSE

A graphical user interface for controlling and monitoring an interferometer device
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Fix: Missing "version" property when writing measure script files #701

Closed alexdewar closed 1 week ago

alexdewar commented 1 week ago

As this is a bug, I thought it best to try to merge a fix ASAP so it doesn't get in the way of development.

As @dalonsoa suggested, it would be better if we had a unit test that checks whether the measure script YAML files we're saving are actually valid according to the schema, but I didn't have time to do this properly now, so I've opened an issue: #700.

Fixes #699.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.30%. Comparing base (23f81ad) to head (1c1fb22). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #701 +/- ## ======================================= Coverage 86.30% 86.30% ======================================= Files 69 69 Lines 3549 3549 ======================================= Hits 3063 3063 Misses 486 486 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.