search

ImperialCollegeLondon / Faraday-liionsden

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Refactor ExperimentView #195

Open dandavies99 opened 2 years ago

dandavies99 commented 2 years ago

Consider refactoring ExperimentView when the plotting framework is more mature. A lot of the logic to do with plotting could probably be moved to separate functions in plots.py.

For larger datasets, plotting these each time the experiment detail page is loaded causes very slow loading times. It would be better to cache / save the plot after initial upload.

Aha! Link: https://imperial-college-ict.aha.io/requirements/RSE-132-5

dandavies99 commented 1 year ago

In addition to the above, the get_tables and get_tables_data methods should be reviewed to ensure they are clear and as simple as possible.