Closed jezcope closed 4 years ago
Merging #62 into develop will increase coverage by
9.04%
. The diff coverage is91.11%
.
@@ Coverage Diff @@
## develop #62 +/- ##
===========================================
+ Coverage 65.08% 74.13% +9.04%
===========================================
Files 5 8 +3
Lines 169 259 +90
===========================================
+ Hits 110 192 +82
- Misses 59 67 +8
Impacted Files | Coverage Δ | |
---|---|---|
r2t2/__main__.py | 0.00% <0.00%> (ø) |
|
r2t2/docstring_reference_parser.py | 86.66% <86.66%> (ø) |
|
r2t2/docstring_parser.py | 100.00% <100.00%> (ø) |
|
r2t2/plain_text_parser.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cdc0923...bd7a2bf. Read the comment docs.
Looking good to me.
Going to close this because the same change has now happened in #67 and that PR also fixes a few resulting issues.
It’s a Mypy directive to ignore the static type checking. Have a look at this:
From: Daniel Ecer notifications@github.com Sent: Thursday, September 10, 2020 6:13:48 PM To: ImperialCollegeLondon/R2T2 R2T2@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [ImperialCollegeLondon/R2T2] Remove pytest.ini that causes pytest to issue warnings (#62)
@de-code commented on this pull request.
In docs/conf.pyhttps://github.com/ImperialCollegeLondon/R2T2/pull/62#discussion_r482899838:
@@ -4,6 +4,8 @@
list see the documentation:
https://www.sphinx-doc.org/en/master/usage/configuration.html
+# type: ignore
I didn't know that type comment. Do you have a reference for it?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ImperialCollegeLondon/R2T2/pull/62#pullrequestreview-481737352, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABOQHLU3KHJAH4JB5R76ZHLSFECMZANCNFSM4QUUAMVQ.
Also add
# type: ignore
todocs/conf.py
so that it doesn't cause failures from mypy analysis.Fixes #58