ImperialCollegeLondon / SWMManywhere

SWMManywhere is used to derive and simulate a sewer network anywhere in the world
https://imperialcollegelondon.github.io/SWMManywhere/
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Joss paper #313

Closed barneydobson closed 2 weeks ago

barneydobson commented 1 month ago

Description

@cheginit this is a super quick draft I thought I'd prepare for a JOSS paper. I've just gone for something similar to the WSIMOD one. I haven't checked in detail at all and definitely need to polish it - but just wanted to check that you're happy with the broad format (i.e., summary = 1 para, statement of need = 1 para literature + 1 para software, outlook/limitations = 1 para). In particular I'm aware the literature para needs some significant improvement!

OK I've actually reduced it and moved the literature into the summary, but I think it works better, LMK what you think (@cheginit )

Fixes #337

Type of change

Key checklist

Further checks

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.79%. Comparing base (fb919bc) to head (99167e8). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #313 +/- ## ========================================== + Coverage 87.77% 87.79% +0.01% ========================================== Files 22 22 Lines 2217 2220 +3 Branches 280 280 ========================================== + Hits 1946 1949 +3 Misses 194 194 Partials 77 77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cheginit commented 1 month ago

The structure is good. Just try to keep it below 1000 words.

barneydobson commented 2 weeks ago

@cheginit any closing remarks for this?

cheginit commented 2 weeks ago

I added some comments. Also, please make sure that you can successfully compile the paper locally following JOSS's instructions here.