Closed fvalka closed 4 years ago
This looks good to me.
We should change this a bit by not running on github machines but a self-hosted server. We need to get that in the CD script now and also I think currently we are pushing web directory after run but that directory doesn't exist on covid19estimates. We will need to change this to make sure we output in the correct folder.
Working on it to get to run on Azure. The web folder part is correct, it tells the deploy GitHub action which subfolder to us as it's root folder when committing and pushing into the other repo, I've tested it yesterday from my fork and it pushes it correctly into the master of covid19estimates, keeping the current files and only replacing new files.
Thanks, that's great. Where is the HTML code for the website by the way, currently? @fvalka
@harrisonzhu508 in the private covid19estimates repo, under the ImperialCollegeLondon user, you should have access there, otherwise @s-mishra can surely give it to you :-)
@harrisonzhu508 I have given you maintainer access on the website. You need to accept the invite
Great thanks - got it
@fvalka I have made a plethora of chnages that will mkae your life easier now once you do a pull on your side.
Hi!
Quick update: I've got the Dockerimage to work, finally! ;-)
And created a pull request: https://github.com/ImperialCollegeLondon/covid19model/pull/45
So far it doesn't work on Azure Batch Shipyard yet, but that seems to be an issue with the configuration files there which I'm working on.
Good night and all the best Fabian
On 2020-04-10 15:13, Swapnil Mishra wrote:
@fvalka [1] I have made a plethora of chnages that will mkae your life easier now once you do a pull on your side.
-- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [2], or unsubscribe [3].
Links:
[1] https://github.com/fvalka [2] https://github.com/ImperialCollegeLondon/covid19model/pull/39#issuecomment-612022647 [3] https://github.com/notifications/unsubscribe-auth/AD5XSEIBI5GR2AH46NYI7V3RL4LQBANCNFSM4MEU64VA
Necessary changes to your repo for making it work
Secrets/Token Set-Up
Execution of the model run/workflow
The workflow can be started in two different ways:
Changes to the R base code
Font-workaround
The SVG output in the Docker image creates an invalid font-name "Aerial". I've searched the source code of the R libraries used and found no reference to it.
Changes to the current CI pipeline and Dockerimage
New workflow