search

ImperialCollegeLondon / django-drf-filepond

A Django app providing a server implemention for the Filepond file upload library
BSD 3-Clause "New" or "Revised" License
105 stars 40 forks source link

GHA issues with older versions of Python #85

Closed jcohen02 closed 1 year ago

jcohen02 commented 1 year ago

In the updated test configuration using tox and running across multiple Python versions, the attempt to run on Python 2.7, 3.5 and 3.6 fails. This seems to be because, when using ubuntu-latest for the OS, we're getting 22.04 runners which don't have these older versions of Python available.

This seems to be a common issue discussed in issue 544 of the setup-python repo. One temporary workaround seems to be to switch the version of Ubuntu being used to 20.04. This is an option but ideally, it would be good to be running on 22.04 where possible.

There are a couple of options here, one is simply to switch, for now to 20.04. The other is to update the GHA matrix to something similar to the example shown in https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#matrix-testing.

Here we could put an exclude on 20.04 for the newer versions and an exclude on 22.04 for the older versions. This may be a little messy to maintain but, for now, while the older Python versions are being supported, it may be more sustainable.

jcohen02 commented 1 year ago

This is fixed using the second approach described above - testing for older Python versions is run on 20.04 but for new versions we run on ubuntu-latest - fix is committed in 29c6d9fee6e754614f2b42b97a031b34d47c55e4 / 7b24d19f8ce3c37b2d06f1fc4212e9ea91b57bf9.