search

ImperialCollegeLondon / django-drf-filepond

A Django app providing a server implemention for the Filepond file upload library
BSD 3-Clause "New" or "Revised" License
103 stars 39 forks source link

Fix deprecation warnings #87

Closed Incred closed 1 year ago

Incred commented 1 year ago
Incred commented 1 year ago

Just one other question - I was a little confused by the PR title "Fix deprecation warnings", I presume this refers only to the flake8 formatting warnings? I don't see any deprecation warnings when I run the test suite so just wanted to check I'm not missing anything.

When I run tox (with python3.10 env) the following warning happen: 

tests/test_chunked_uploaded_file.py:219                                                                                                                                                                              
  /home/incred/dev/django-drf-filepond/tests/test_chunked_uploaded_file.py:219: DeprecationWarning: invalid escape sequence '\('                                                                                     
    OSError, ('File must be opened with "open\(mode\)" before '                                                                                                                                                      

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

So I've fixed it here by using raw string to use escape symbols properly

jcohen02 commented 1 year ago

Just one other question - I was a little confused by the PR title "Fix deprecation warnings", I presume this refers only to the flake8 formatting warnings? I don't see any deprecation warnings when I run the test suite so just wanted to check I'm not missing anything.

When I run tox (with python3.10 env) the following warning happen:

tests/test_chunked_uploaded_file.py:219                                                                                                                                                                              
  /home/incred/dev/django-drf-filepond/tests/test_chunked_uploaded_file.py:219: DeprecationWarning: invalid escape sequence '\('                                                                                     
    OSError, ('File must be opened with "open\(mode\)" before '                                                                                                                                                      

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

So I've fixed it here by using raw string to use escape symbols properly

Ah, ok, great, thanks for the explanation, I missed that (I was wondering about the raw string! 🙂). This is all looking good so I'll merge.