ImperialCollegeLondon / epidemia

epidemia package
https://imperialcollegelondon.github.io/epidemia/index.html
47 stars 15 forks source link

Implement plot, summary, print methods for 'epimodel' class #5

Closed jscott6 closed 4 years ago

jscott6 commented 4 years ago

Should have plotting methods for model fit objects ('epimodels'). Nice to have ability to plot reproduction number over time in particular. Could perhaps use 'Bayesplot' package.

jscott6 commented 4 years ago

Plots added - can plot evolution of reproduction number, predicted observations and underlying infections using plot_rt(), plot_obs() and plot_infections() respectively.

jonathanishhorowicz commented 4 years ago

Would it be useful if these methods supported facetting? If the group argument was a vector we could facet on the groups. I have done this for the Rt plot and can add it to the others if others think it is useful.

flaxter commented 4 years ago

Great idea!

On Sun, 14 Jun 2020, 18:02 Jonathan Ish-Horowicz, notifications@github.com wrote:

Would it be useful if these methods supported facetting? If the group argument was a vector we could facet on the groups. I have done this for the Rt plot and can add it to the others if others think it is useful.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ImperialCollegeLondon/epidemia/issues/5#issuecomment-643793883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOPW2HSGWTRG4IZLBZQ5LRWT7CJANCNFSM4N4VQWLQ .

agandy commented 4 years ago

Agreed


From: Seth Flaxman notifications@github.com Sent: Sunday, June 14, 2020 7:12:31 PM To: ImperialCollegeLondon/epidemia epidemia@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [ImperialCollegeLondon/epidemia] Implement plot, summary, print methods for 'epimodel' class (#5)

This email from notifications@github.com originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders listhttps://spam.ic.ac.uk/SpamConsole/Senders.aspx to disable email stamping for this address.

Great idea!

On Sun, 14 Jun 2020, 18:02 Jonathan Ish-Horowicz, notifications@github.com wrote:

Would it be useful if these methods supported facetting? If the group argument was a vector we could facet on the groups. I have done this for the Rt plot and can add it to the others if others think it is useful.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ImperialCollegeLondon/epidemia/issues/5#issuecomment-643793883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAOPW2HSGWTRG4IZLBZQ5LRWT7CJANCNFSM4N4VQWLQ .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ImperialCollegeLondon/epidemia/issues/5#issuecomment-643801979, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA7JUZSK3JKWTKKGZZ3M3ATRWUHI7ANCNFSM4N4VQWLQ.

jonathanishhorowicz commented 4 years ago

I have pushed this to develop and updated the docs

jscott6 commented 4 years ago

I have pushed this to develop and updated the docs

This looks great - thanks a lot!

agandy commented 4 years ago

@jscott6 - can we close this one?