ImperialCollegeLondon / fair-data-repository

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Add Mypy? #27

Closed cc-a closed 4 months ago

cc-a commented 4 months ago

Provides the infrastructure for mypy usage via pytest-mypy. Uses a loose configuration that effectively makes typehinting optional. Adds hints to an oauth handler as an example.

I'm not 100% on this. Given the lack of typing in the Invenio and wider Flask ecosystems (Flask itself is typed) there are some questions about how much value we would derive.

Some pros:

Some cons:

cc-a commented 4 months ago

@J4bbi @Steven-Eardley could one of you approve so this can be merged?

cc-a commented 4 months ago

Ugh... just noticed this was opened against main and we've swapped to using develop. I'll need to close and open an new one.