search

ImperialCollegeLondon / fast-and-curious

The materials for the 2024 Fast and the Curious Hackathon run by the Research Computing and Data Science at the Graduate School
https://blogs.imperial.ac.uk/postgraduatenoticeboard/2024/06/04/rcds-hackathon-2024-12-july-2024-sk-campus/
BSD 3-Clause "New" or "Revised" License
2 stars 5 forks source link

Incorrect base Solution for five_numbers_monte_carlo and largest_inscribed_triangle #2

Closed cmcooling closed 2 months ago

cmcooling commented 3 months ago

When I run the final "Overview" cell in testing_interface.ipynb, it tells me that the base code for these two projects fails. The basic version of the code should pass all the tests, so either the tests or the basic code needs to be tweaked.

cmcooling commented 3 months ago

There's also some errors generated from the uncertain_cubiods project - I'll take care of those.

cmcooling commented 3 months ago

@jianlianggao you mentioned you weren't sure which messages I meant the other day.

When I run the "Overview" code cell in testing_interface.ipynb I receive the following messages:

image

This makes it look as thought the student case is failing the tests. There are also a number of other print messages that shouldn't be there. run_tests runs its test with print_project_level_output set to False. This means that there should be nothing printed by the call to those tests. The only printing should from the print statements at the end of run_tests.

cmcooling commented 3 months ago

If you'd still like to meet to discuss this, let me know.

cmcooling commented 2 months ago

@jianlianggao could you please correct this when you have a moment?

cmcooling commented 2 months ago

I've removed this project from the testing notebook and the tests. I copied the text of the description to students/five-numbers_monte_carlo.py where it's a comment, so it can be retrieved later if it's needed.