ImperialCollegeLondon / gridlington-vis

BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Move titles to graphs #93

Closed tsmbland closed 10 months ago

tsmbland commented 10 months ago

Description

Moving titles to graphs rather than having them as their own div. Also set up some decorators to abstract some of the figure formatting. I've now set the total figure height in the market and supplydemand views to 100% to eliminate the black bar. I've left agent for now for reasons outlined below (also because layout for agent view is still tbd).

Also moving some figure formatting commands outside of if statements so things like axis labels and titles show even when the data is empty (i.e. upon startup)

Still to do:

Close #81 Close #62

Type of change

Key checklist

tsmbland commented 10 months ago

I think this is ready now. The grey column issue is fixed in the grid layout PR. I'm going to sort out titles for SVGs in another PR to avoid conflicts

AdrianDAlessandro commented 10 months ago

Also, I think the position of the time-stamp needs revising Screenshot 2023-11-29 at 17 37 44

tsmbland commented 10 months ago

I've got this situation where the intraday market system and balancing market graphs no longer have a fixed x-axis range.

This is because I removed the decorator from the double-y graphs. I've just added the relevant commands back into the figure functions for now, rather than adapt the decorator to support double-y, as we're going the get rid of the double-y graphs anyway