ImperialCollegeLondon / gridlington-vis

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

Abstract grid layout #94

Closed tsmbland closed 10 months ago

tsmbland commented 10 months ago

Description

Abstracting grid layout for figures into a new class. You specify the number of rows and columns in the grid, then add each element (div) individually before building the grid.

Not currently suitable for any layouts more complex than a grid. Could probably make this more flexible, as discussed below and on teams:

allowing number of rows/columns to be dynamically adjusted when a new element is added (specifying width/height when you add the element)
supporting a different number of columns per row
using width/height multipliers instead of specifying absolute values

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (non-breaking, back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (whatever its nature)

Key checklist

[ ] All tests pass (python -m pytest)
[ ] Pre-commit hooks run successfully (pre-commit run --all-files)

tsmbland commented 10 months ago

@AdrianDAlessandro Thoughts on this approach before I go any deeper?