ImperialCollegeLondon / intermediate_grad_school_git_course

Intermediate Git and GitHub for Effective Collaboration
https://imperialcollegelondon.github.io/intermediate_grad_school_git_course/
Other
3 stars 1 forks source link

Fix `make lesson-check` warnings and add to CI workflow #95

Closed alexdewar closed 3 weeks ago

alexdewar commented 3 weeks ago

This PR fixes/suppresses all make lesson-check warnings and adds it as a step in our CI workflow.

It doesn't give quite as many helpful warnings as I was hoping for, but I still think there's some value in using it (and in any case I've done it now :upside_down_face:).

Commit summary:

There is a newer version of the Carpentries template that we could move to which may add some more checks and/or fix the false positive we're getting, but in any case we're going to move to the new Workbench tool at some point (#66) so it's probably not worth it.

Closes #72.

alexdewar commented 3 weeks ago

Oops -- getting a CI error. Converting to draft till I fix

alexdewar commented 3 weeks ago

Sorted. I think this is good to go now.