search

ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
23 stars 9 forks source link

More doctest fixes #110

Closed MarionBWeinzierl closed 1 year ago

MarionBWeinzierl commented 1 year ago

If I run doctests. e.g. poetry run python -m doctest pyrealm/pmodel/pmodel.py, I get several of the following type of error messages:

Failed example: np.round(mod_c4.gpp, 5) Expected: 103.25886 Got: array([103.25886])

This is a similar issue as in #92

davidorme commented 1 year ago

I do not get this on develop - that doctest no longer uses np.round?

https://github.com/ImperialCollegeLondon/pyrealm/blob/4454afbbc83af33a6455888f26949ac93530614c/pyrealm/pmodel/pmodel.py#L340-L341

MarionBWeinzierl commented 1 year ago

Ah, I am on main!

-- Dr Marion Weinzierl Senior Research Software Engineer Institute of Computing for Climate Science (ICCS) University of Cambridge

From: David Orme @.> Sent: 19 September 2023 16:55 To: ImperialCollegeLondon/pyrealm @.> Cc: Marion Weinzierl @.>; Author @.> Subject: Re: [ImperialCollegeLondon/pyrealm] More doctest fixes (Issue #110)

I do not get this on develop - that test no longer uses np.round?

https://github.com/ImperialCollegeLondon/pyrealm/blob/develop/pyrealm/pmodel/pmodel.py#L340-L341

— Reply to this email directly, view it on GitHubhttps://github.com/ImperialCollegeLondon/pyrealm/issues/110#issuecomment-1725939799, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANOKODBODKRMETBADMK3T53X3G567ANCNFSM6AAAAAA46QY3SI. You are receiving this because you authored the thread.Message ID: @.***>