search

ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
23 stars 9 forks source link

Create a new evaporation constants dataclass #124

Closed davidorme closed 9 months ago

davidorme commented 1 year ago

In order to integrate SPLASH, the constants imported as global variables in the evap.py module of the feature branch in https://github.com/ImperialCollegeLondon/pyrealm/pull/69 need to be extracted into a pyrealm style configurable dataclass.

There may be overlap with the constants used in #121, so it is possible we also need a general CoreConstants class to avoid duplication?

Suggested location: pyrealm.core.evap_constants.py

davidorme commented 9 months ago

As with #121, to avoid creating multiple constants classes that need adding as arguments to classes and methods, this is better addressed by extending the CoreConsts introduced by #139.