ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Adopt `core.evaporation` functionality into `feature/splash_v1` #126

Closed davidorme closed 8 months ago

davidorme commented 11 months ago

Following on from the merging of #125 into develop, this functionality then needs to be adopted in the SPLASH implementation:

Some of these functions overlap existing pyrealm functions: density_h2o is calc_density_h2o_chen and elv2pres is calc_patm, although there are differences in the definition of the standard atmosphere. The P Model uses a standard temperature for photosynthetic processes of 25°C and this is also (probably incorrectly) being used in calc_patm for atmospheric corrections - 15°C seems canonical for this application.

Depends: #124, #125

davidorme commented 8 months ago

Uses CoreConsts not a specific EvapConsts but otherwise complete.