Following on from the merging of #125 into develop, this functionality then needs to be adopted in the SPLASH implementation:
[x] Merge develop into feature/splash_v1 (see #69)
[x] Replace calls to the branch splash/evap.py functionality with the integrated pyrealm.core.evaporation functions.
[x] Update splash arguments to pass the required EvapConsts (#124) dataclasses down as required.
Some of these functions overlap existing pyrealm functions: density_h2o is calc_density_h2o_chen and elv2pres is calc_patm, although there are differences in the definition of the standard atmosphere. The P Model uses a standard temperature for photosynthetic processes of 25°C and this is also (probably incorrectly) being used in calc_patm for atmospheric corrections - 15°C seems canonical for this application.
Following on from the merging of #125 into
develop
, this functionality then needs to be adopted in the SPLASH implementation:develop
intofeature/splash_v1
(see #69)splash/evap.py
functionality with the integratedpyrealm.core.evaporation
functions.splash
arguments to pass the requiredEvapConsts
(#124) dataclasses down as required.Some of these functions overlap existing
pyrealm
functions:density_h2o
iscalc_density_h2o_chen
andelv2pres
iscalc_patm
, although there are differences in the definition of the standard atmosphere. The P Model uses a standard temperature for photosynthetic processes of 25°C and this is also (probably incorrectly) being used incalc_patm
for atmospheric corrections - 15°C seems canonical for this application.Depends: #124, #125