ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Create core module #139

Closed MarionBWeinzierl closed 8 months ago

MarionBWeinzierl commented 10 months ago

This PR closes #75 . It creates the described core module and moves the utilities and hygro modules as submodules into the core. It also adapts the documentation to reflect these changes.

Updated by @davidorme:

I think we can now move this out of draft status and review it:

From #75:

codecov-commenter commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b9a454f) 93.38% compared to head (31fd2d3) 93.43%.

Files Patch % Lines
pyrealm/core/water.py 96.33% 4 Missing :warning:
pyrealm/constants/core_const.py 95.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #139 +/- ## =========================================== + Coverage 93.38% 93.43% +0.05% =========================================== Files 21 23 +2 Lines 1134 1143 +9 =========================================== + Hits 1059 1068 +9 Misses 75 75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 10 months ago

Looks good so far!

davidorme commented 8 months ago

I left some tests in pmodel that should properly now be in tests\unit\core. I had forgotten that #151 has already been merged into develop, so was leaving them until they could be moved into the new structure, but they can so should be here.