Closed MarionBWeinzierl closed 8 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
b9a454f
) 93.38% compared to head (31fd2d3
) 93.43%.
Files | Patch % | Lines |
---|---|---|
pyrealm/core/water.py | 96.33% | 4 Missing :warning: |
pyrealm/constants/core_const.py | 95.23% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good so far!
I left some tests in pmodel
that should properly now be in tests\unit\core
. I had forgotten that #151 has already been merged into develop, so was leaving them until they could be moved into the new structure, but they can so should be here.
This PR closes #75 . It creates the described core module and moves the utilities and hygro modules as submodules into the core. It also adapts the documentation to reflect these changes.
Updated by @davidorme:
I think we can now move this out of draft status and review it:
From #75:
core
module is now created and includesutilities
,hygro
,water
andpressure
.pmodel.functions
.CoreConst
constants class to covercore
module functions. This also closes #76.pmodel
module method and function signatures are updated to addcore_const
where required, and then their code is updated to use the correct constant instances.api
entry in the docs to expose the docstrings on the core functionality.