Closed tztsai closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
dbdff0f
) 94.09% compared to head (2c9054e
) 94.09%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There is now a formatting error flagged by the linting which needs to be resolved:
There is now a formatting error flagged by the linting which needs to be resolved:
I have fixed the line with extra length.
Now it has trailing whitespace (don't worry, happens to me all the time!):
This shouldn't happen if pre-commit
is installed? @TZTsai - have you got pre-commit
set up on your machine? If you have then it shouldn't permit you to push commits that fail the qa
action. That's actually described in CONTRIBUTING.md
😄
This shouldn't happen if
pre-commit
is installed? @TZTsai - have you gotpre-commit
set up on your machine? If you have then it shouldn't permit you to push commits that fail theqa
action. That's actually described inCONTRIBUTING.md
😄
Ah sorry. I do have pre-commit
installed, but I directly edited the file on GitHub.
That explains it 😄
Fixes #144
Add the instruction of using Git LFS in
CONTRIBUTING.md
to download the datasets, in order to pass two tests related to the datasetinputs_data_24.25.nc
.