ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Update CONTRIBUTING.md #146

Closed tztsai closed 9 months ago

tztsai commented 9 months ago

Fixes #144

Add the instruction of using Git LFS in CONTRIBUTING.md to download the datasets, in order to pass two tests related to the dataset inputs_data_24.25.nc.

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dbdff0f) 94.09% compared to head (2c9054e) 94.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #146 +/- ## ======================================== Coverage 94.09% 94.09% ======================================== Files 21 21 Lines 1134 1134 ======================================== Hits 1067 1067 Misses 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MarionBWeinzierl commented 9 months ago

There is now a formatting error flagged by the linting which needs to be resolved: image

tztsai commented 9 months ago

There is now a formatting error flagged by the linting which needs to be resolved: image

I have fixed the line with extra length.

MarionBWeinzierl commented 9 months ago

Now it has trailing whitespace (don't worry, happens to me all the time!): image

davidorme commented 9 months ago

This shouldn't happen if pre-commit is installed? @TZTsai - have you got pre-commit set up on your machine? If you have then it shouldn't permit you to push commits that fail the qa action. That's actually described in CONTRIBUTING.md 😄

tztsai commented 9 months ago

This shouldn't happen if pre-commit is installed? @TZTsai - have you got pre-commit set up on your machine? If you have then it shouldn't permit you to push commits that fail the qa action. That's actually described in CONTRIBUTING.md 😄

Ah sorry. I do have pre-commit installed, but I directly edited the file on GitHub.

davidorme commented 9 months ago

That explains it 😄