Closed tztsai closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
02a8ab8
) 94.09% compared to head (80bfde6
) 93.38%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks good. I am not sure that long-term we want the graphical profiling outputs in the repository. Rather, I'd expect that it is enough to describe in the documentation how to get them. But for now I am happy to have them included as latest profiling results, as long as they are overwritten (and we don't accumulate pngs).
Thanks! I implemented the feature of generating graphical profiling outputs because it was one of the tasks specified in #141, i.e. "automate call graph creation". Therefore I imagined it was your intention to automatically create visualization of the profiling results in the CI workflow. Maybe I misunderstood.
I am not sure that long-term we want the graphical profiling outputs in the repository. Rather, I'd expect that it is enough to describe in the documentation how to get them
@MarionBWeinzierl and @tztsai - slow to reply to this, but in the longer term I think the generation of these plots should move into the documentation. They can be dynamically generated when the HTML docs are built and so the plots there could show tagged builds and develop
.
Description
Updated the CI workflow so that when there is a
pull_request
event (created, ready for review, merged, etc.), it will automatically run profiling using the LFS dataset. Subsequently it will report the profiling results in a CSV file, generate the call graph and some performance benchmark plots in theprofiling/
folder. These generated files will be added to a new Git commit and pushed to the current branch right before this branch is going to be merged. However, the last feature requires that the branch to merge into must enable the "Require merge queue" setting in the branch protection rules (see https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue).Fixes #142, #152
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks