ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Let `PModelConst` inherit `CoreConst` #161

Open tztsai opened 8 months ago

tztsai commented 8 months ago

In PR #139, in many places a single object const is replaced by two objects core_const and pmodel_const, and the developer also has to keep in mind which class (CoreConst or PModelConst) a particular constant belongs to when implementing functions. If PModelConst can inherit CoreConst, the code may be more concise (as only a single ConstantsClass object is needed in each function or method).