In PR #139, in many places a single object const is replaced by two objects core_const and pmodel_const, and the developer also has to keep in mind which class (CoreConst or PModelConst) a particular constant belongs to when implementing functions. If PModelConst can inherit CoreConst, the code may be more concise (as only a single ConstantsClass object is needed in each function or method).
In PR #139, in many places a single object
const
is replaced by two objectscore_const
andpmodel_const
, and the developer also has to keep in mind which class (CoreConst
orPModelConst
) a particular constant belongs to when implementing functions. IfPModelConst
can inheritCoreConst
, the code may be more concise (as only a singleConstantsClass
object is needed in each function or method).