Regression test of `splash.evap` does not pass

ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.

https://pyrealm.readthedocs.io/

MIT License

19 stars 8 forks source link

Regression test of `splash.evap` does not pass #173

Closed tztsai closed 7 months ago

tztsai commented 7 months ago

After the hot fix in #171, the assertion in tests/regression/test_evap.py fails.

davidorme commented 7 months ago

Good catch - that is odd, given that the higher level test of the whole SPLASH process passes.

davidorme commented 7 months ago

OK - got it. The AET component of the water balance equation is the evapotranspiration loss calculated from the previous day's soil moisture. Need to prepend the spun up initial wn and drop the last day on the inputs to estimate_aet. I've added the fix to the hotfix PR #171 that revealed this test bug.