Some tests produce out of bound errors

ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.

https://pyrealm.readthedocs.io/

MIT License

19 stars 8 forks source link

Some tests produce out of bound errors #174

Closed tztsai closed 7 months ago

tztsai commented 7 months ago

I changed the function bounds_checker from producing a warning to raising an error when the input contains out-of-bound values. After that, however, some of the existing tests cannot pass.

davidorme commented 7 months ago

@tztsai Can you link this into other issues or PRs please - there's no context to find out where this bug appeared or why it was closed.

tztsai commented 7 months ago

These errors were just because those failing tests expect UserWarning instead of ValueError. Therefore I thought there's no bug and closed this issue.

davidorme commented 7 months ago

Thanks - which PR was this in?