ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Add additional boundary checks in the `Splash` module #175

Closed tztsai closed 7 months ago

tztsai commented 7 months ago

Boundary checks of variables like lat, sf, tc, pn, etc. could be added in the initialization of SplashModel, and checks of the input variable wn_init in methods like estimate_initial_soil_moisture, estimate_daily_water_balance, calculate_soil_moisture would also be beneficial.

tztsai commented 7 months ago

Closed by PR #170