ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Draft new subdaily PModel class that uses the `PModel` and `OptimalChi` code directly, #177

Closed davidorme closed 6 months ago

davidorme commented 7 months ago

Is your feature request related to a problem? Please describe.

As noted in #119, the existing subdaily model is pinned to the Prentice14 approach for C3 plants. The internal code includes a reimplementation of the same calculations as the PModel using method_optchi = 'prentice14'. The main barrier to implementing a new approach that integrates that code is in handling slowly responding xi, which was raised in #119 and then is implemented in #172.

Describe the solution you'd like Build a new subdaily implementation around an existing PModel - it basically adds observation dates to a fitted PModel and that is then used to estimate slow responses.