Closed davidorme closed 6 months ago
Attention: Patch coverage is 95.83333%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 94.91%. Comparing base (
8ace3d7
) to head (6687d63
).
Files | Patch % | Lines |
---|---|---|
pyrealm/pmodel/new_subdaily.py | 94.73% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks perfect to me.
Description
This PR builds on #172 to use the new
OptimalChi
methods to allow all approaches to be used in estimating a subdaily PModel. This radically simplifies the code compared to the currentFastSlowPModel
because all of the existing code within thepmodel
module can be re-used more efficiently.The PR:
Fixes #177 - but departs from the original plan that used an existing PModel as an input. This stands alone but provides the conversion function.
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks