ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

New subdaily pmodel implementation #183

Closed davidorme closed 6 months ago

davidorme commented 6 months ago

Description

This PR builds on #172 to use the new OptimalChi methods to allow all approaches to be used in estimating a subdaily PModel. This radically simplifies the code compared to the current FastSlowPModel because all of the existing code within the pmodel module can be re-used more efficiently.

The PR:

Fixes #177 - but departs from the original plan that used an existing PModel as an input. This stands alone but provides the conversion function.

Type of change

Key checklist

Further checks

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 95.83333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.91%. Comparing base (8ace3d7) to head (6687d63).

Files Patch % Lines
pyrealm/pmodel/new_subdaily.py 94.73% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #183 +/- ## =========================================== + Coverage 93.80% 94.91% +1.11% =========================================== Files 28 29 +1 Lines 1468 1535 +67 =========================================== + Hits 1377 1457 +80 + Misses 91 78 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tztsai commented 6 months ago

Looks perfect to me.