ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Fix time handling in Splash #186

Closed tztsai closed 5 months ago

tztsai commented 6 months ago

Description

The update uses CalendarDay.days_in_year to find the number of days after a whole year in the estimate_initial_soil_moisture method of SplashModel. An additional check is also added in __init__ to ensure that the length of dates matches the shape of other variables.

Fixes #165

Type of change

Key checklist

Further checks

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.88%. Comparing base (8f7d032) to head (b4ec7c6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #186 +/- ## ============================================ + Coverage 0 94.88% +94.88% ============================================ Files 0 28 +28 Lines 0 1505 +1505 ============================================ + Hits 0 1428 +1428 - Misses 0 77 +77 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

davidorme commented 5 months ago

I've resolved the pyproject.toml and poetry.lock conflict - just different package order in the pyproject.toml dev dependencies