Use a function `eval_poly` for polynomial evaluation

[tztsai]

Description

A function eval_poly is implemented in pyrealm.core.utilities using Horner's method for polynomial evaluation and used to simplify H2O density calculation and specific heat calculation of air.

Fixes #167

Type of change

• [x] Optimization (back-end change that speeds up the code)

Key checklist

• [x] Make sure you've run the pre-commit checks: $ pre-commit run -a
• [x] All tests pass: $ poetry run pytest

Further checks

• [x] Code is commented, particularly in hard-to-understand areas
• [x] Tests added that prove fix is effective or that feature works

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.47%. Comparing base (858e5e9) to head (c4361ec).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #187 +/- ## =========================================== - Coverage 94.58% 94.47% -0.12% =========================================== Files 28 28 Lines 1514 1483 -31 =========================================== - Hits 1432 1401 -31 Misses 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[davidorme]

I fixed the qa failure - somehow a black issue had snuck past pre-commit. The tests are failing but I think the docs failure is a VM fail - it runs on the push but not on the pr event.

[davidorme]

I've pushed an update of the failing test and expanded it a bit to make sure it handles different inputs. Can you make sure you run pytest before pushing commits? Particularly when working on tests, making sure that things run locally before setting off GitHub Actions can save a lot of waiting around!

[tztsai]

I've pushed an update of the failing test and expanded it a bit to make sure it handles different inputs. Can you make sure you run pytest before pushing commits? Particularly when working on tests, making sure that things run locally before setting off GitHub Actions can save a lot of waiting around!

Thanks for the update! I'll make sure the run the tests before pushing.