Closed tztsai closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.47%. Comparing base (
858e5e9
) to head (c4361ec
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I fixed the qa
failure - somehow a black
issue had snuck past pre-commit. The tests are failing but I think the docs
failure is a VM fail - it runs on the push
but not on the pr
event.
I've pushed an update of the failing test and expanded it a bit to make sure it handles different inputs. Can you make sure you run pytest
before pushing commits? Particularly when working on tests, making sure that things run locally before setting off GitHub Actions can save a lot of waiting around!
I've pushed an update of the failing test and expanded it a bit to make sure it handles different inputs. Can you make sure you run
pytest
before pushing commits? Particularly when working on tests, making sure that things run locally before setting off GitHub Actions can save a lot of waiting around!
Thanks for the update! I'll make sure the run the tests before pushing.
Description
A function
eval_poly
is implemented inpyrealm.core.utilities
using Horner's method for polynomial evaluation and used to simplify H2O density calculation and specific heat calculation of air.Fixes #167
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks