Open surbhigoel77 opened 6 months ago
This is a WIP, @surbhigoel77 ? Can you convert to a draft (link in Reviewers pane).
Also - have you branched this off the feature/new-unit-tests
branch, rather than develop
? I think it is bringing the commits to that PR with it?
Also - have you branched this off the
feature/new-unit-tests
branch, rather thandevelop
? I think it is bringing the commits to that PR with it?
Yes, I realised that when I pushed changes to fastslow-initval
. The commit history shows changes from feature/new-unit-tests
branch as well.
No bother - it isn't a big deal 😄 I guess we could git revert
those commits on this branch
Attention: Patch coverage is 83.33333%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 95.24%. Comparing base (
2072e0b
) to head (9e3d36d
). Report is 34 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
pyrealm/pmodel/subdaily.py | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
The
subdaily
module uses an extended form of PModel called theFastSlowPModel
. to estimate two categories of variables - fast variables (that respond to environmental changes instantaneously) and slow variables (that take time to respond to these changes). The module uses amemory_effect
functions that facilitates the calculation of the slow variables as a combination of their lag values and optimal values.In the current implementation of
subdaily
, at the start of the model run, the slow variables take the optimal value as the initial value and update the succeeding values using the:$R{t} = R{t-1}(1 - \alpha) + O_{t} \alpha$
This PR intends to use an approach in which the last available realised value is used as the initial value for $x{i}$, $V_{max}$ and $J{max}$.
Fixes #82
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks