Closed tztsai closed 5 months ago
Shouldn't the function inform whether the iteration has reached equilibrium before returning the array?
Yeah - that would be useful - we should add a warning to flag that the returned sequence doesn't meet the convergence criteria.
Caught that bug that was causing the tests to fail.
Attention: Patch coverage is 74.07407%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 94.58%. Comparing base (
8f7d032
) to head (7626476
).
Files | Patch % | Lines |
---|---|---|
pyrealm/splash/splash.py | 74.07% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
I replaced
np.max
withnp.nanmax
when calculating the maximum difference between the start of year soil moisture and the final day of the year and then update the start point to the end of year in theestimate_initial_soil_moisture
method of theSplash
model, to output more meaningful error messages when running this method.Fixes #192
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks