Closed davidorme closed 5 months ago
Attention: Patch coverage is 96.55172%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 94.88%. Comparing base (
b41b416
) to head (b2533f3
).
Files | Patch % | Lines |
---|---|---|
pyrealm/pmodel/fast_slow_scaler.py | 95.83% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This is a parallel implementation to #169 that was trying to unpack the test issues seen on that branch. The PR:
FastSlowScaler
.padding
attribute withFastSlowScaler
that manages the wrapping of partial days so that they can be reshaped neatly onto days by observations when extracting daily acclimation data.This also threw up some additional issues to do with handling missing data, giving rise to these changes:
FastSlowScaler.get_daily_means
now has anallow_partial_data
option to handle missing data in the values being averaged to give a daily mean.handle_nan
option to thememory_effect
function then handles missing data in the daily averages by holding over any previous valid value - this should be renamedallow_holdover
to clarify the two roles.The docs have been updated to reflect these changes, particularly the addition of a new section in the user docs on handling missing data in subdaily models.
Fixes #72
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks