ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Allowing incomplete days #194

Closed davidorme closed 5 months ago

davidorme commented 5 months ago

Description

This is a parallel implementation to #169 that was trying to unpack the test issues seen on that branch. The PR:

This also threw up some additional issues to do with handling missing data, giving rise to these changes:

The docs have been updated to reflect these changes, particularly the addition of a new section in the user docs on handling missing data in subdaily models.

Fixes #72

Type of change

Key checklist

Further checks

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 96.55172% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.88%. Comparing base (b41b416) to head (b2533f3).

Files Patch % Lines
pyrealm/pmodel/fast_slow_scaler.py 95.83% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #194 +/- ## =========================================== - Coverage 94.91% 94.88% -0.04% =========================================== Files 29 29 Lines 1535 1543 +8 =========================================== + Hits 1457 1464 +7 - Misses 78 79 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.