Recent PRs have introduced the new implementation of SubdailyModel, which adopts the new OptimalChi structure. Those were added in parallel to the current FastSlowPModel, which should now be removed in preparation for release 1.0.0. The FastSlowScaler should also be renamed - it isn't an intitutive name and we should use something clearer - possibly AcclimationScaler or AcclimationTimer or similar.
Recent PRs have introduced the new implementation of
SubdailyModel
, which adopts the newOptimalChi
structure. Those were added in parallel to the currentFastSlowPModel
, which should now be removed in preparation for release 1.0.0. TheFastSlowScaler
should also be renamed - it isn't an intitutive name and we should use something clearer - possiblyAcclimationScaler
orAcclimationTimer
or similar.Describe the solution you'd like
FastSlowPModel
and associated tests.FastSlowScaler