search

ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
19 stars 8 forks source link

Remove outdated FastSlowPModel #197

Closed davidorme closed 5 months ago

davidorme commented 5 months ago

Recent PRs have introduced the new implementation of SubdailyModel, which adopts the new OptimalChi structure. Those were added in parallel to the current FastSlowPModel, which should now be removed in preparation for release 1.0.0. The FastSlowScaler should also be renamed - it isn't an intitutive name and we should use something clearer - possibly AcclimationScaler or AcclimationTimer or similar.

Describe the solution you'd like

davidorme commented 5 months ago

I've moved fast_slow_scaler.FastSlowScaler to scaler.SubdailyScaler.