ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.

https://pyrealm.readthedocs.io/

MIT License

16 stars 6 forks source link

Fixing profile workflow #211

Closed davidorme closed 3 months ago

davidorme commented 3 months ago

Description

This PR:

Replaces the ubuntu_latest with ubuntu-latest, so it should actually work.
Renames the job from test to a more accurate profiling.
Replaces the simple qa job (just pre-commit) with the complete pyrealm_ci.yaml workflow. Partly to reuse the existing code, partly to give a more robust test. Although, everything coming into develop or main should have been through workflow already.

Fixes #210

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

davidorme commented 3 months ago

Ha - looks like I renamed qa to test and test to profiling. That seems ok.