Closed davidorme closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.23%. Comparing base (
5b50cb4
) to head (77c7fae
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tztsai - Thanks for the comments. I've looked into them and think they're all 'resolved' for this PR. If you're happy, can you approve the PR?
LGTM
Description
This PR restructures the profiling code to do a number of things:
profiling/conftest.py
pmodel
andsubdaily
profile workflows into separate filespytest
to allow the scaling of the payload data to be controlled from the command line. Thesubdaily
andpmodel
tests share the same data and scaling factor option.These changes make the profiling more flexible and helps set up for looking at the scaling of functions with input sizes. It allows commands like the following:
The peak memory size of running the full test set is basically the combined size of each test and is very roughly:
50Mb
splash-profile-scaleup
+ 1Gbpmodel-profile-scaleup
The defaults
--splash-profile-scaleup=125
and--pmodel-profile-scaleup=6
should give about a 6GB size for each dataset. If we could use a single dataset, we'd be able to use bigger loads....Fixes #215
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks