ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
16 stars 6 forks source link

Switched to `pre-commit.ci` #218

Closed davidorme closed 2 months ago

davidorme commented 2 months ago

Description

This PR removes the pre-commit autoupdate workflow. The repo is now enabled with pre-commit.ci, which tests pre-commit status and provides autoupdate in a more integrated way.

There is some redundancy here - our CI GitHub action already runs pre-commit as part of the qa job, so pre-commit.ci is repeating that on each PR, but the way the autoupdate works is better. See here for the status page:

https://results.pre-commit.ci/repo/github/317618141

And we add a badge to README.md 😄

Since this issue was raised by spotting a failed pre-commit update action, I've also run pre-commit autoupdate and then pre-commit run --all and included those changes to get us back on track. The black tool has changed its mind about a couple of line wrappings and some blank lines 🤷‍♂️

Fixes #217

Type of change

Key checklist

Further checks

davidorme commented 2 months ago

Adding pyrealm to pre-commit.ci automatically generated PR #221 that basically repeated much of this PR. With that merged to develop and then back into this PR, all that is left is adding the badge and deleting the old GH action file.