ImperialCollegeLondon / pyrealm

Development of the pyrealm package, providing an integrated toolbox for modelling plant productivity, growth and demography using Python.
https://pyrealm.readthedocs.io/
MIT License
16 stars 6 forks source link

Baseline data and code for two leaf model #240

Closed davidorme closed 1 month ago

davidorme commented 1 month ago

Description

This PR adds pyrealm_build_data/twoleaf, containing some input data files, some notebooks / scripts containing draft implementations of the Two Leaf model and then some parallel outputs to try and align development efforts. This new directory is likely to get reduced and revamped in the near future, but seemed like a good place to share stuff.

The key file is probably the two_leaf_python Myst Markdown notebook (can be run in jupyter-lab) which provides draft TwoLeafIrradiance and TwoLeafAssimilation classes that are structured to work with the existing PModel and SubdailyPModel classes (although it turns out there are some internal inconsistencies in those two class structures!).

Fixes #239

Type of change

Key checklist

Further checks

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.23%. Comparing base (290938a) to head (8d44792).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #240 +/- ## ======================================== Coverage 95.23% 95.23% ======================================== Files 28 28 Lines 1701 1701 ======================================== Hits 1620 1620 Misses 81 81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.