Closed davidorme closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.23%. Comparing base (
290938a
) to head (8d44792
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR adds
pyrealm_build_data/twoleaf
, containing some input data files, some notebooks / scripts containing draft implementations of the Two Leaf model and then some parallel outputs to try and align development efforts. This new directory is likely to get reduced and revamped in the near future, but seemed like a good place to share stuff.The key file is probably the
two_leaf_python
Myst Markdown notebook (can be run injupyter-lab
) which provides draftTwoLeafIrradiance
andTwoLeafAssimilation
classes that are structured to work with the existingPModel
andSubdailyPModel
classes (although it turns out there are some internal inconsistencies in those two class structures!).Fixes #239
Type of change
Key checklist
pre-commit
checks:$ pre-commit run -a
$ poetry run pytest
Further checks